Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP: Bedrock constructor argument corrections. #6824

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

quintes
Copy link

@quintes quintes commented Sep 9, 2024

PHP Bedrock and BedrockRuntime constructor arguments #6823 fix

This pull request will provide the correct arguments to the Bedrock and Bedrock runtime constructors for the PHP examples

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license

@github-actions github-actions bot added the PHP This issue relates to the AWS SDK for PHP label Sep 9, 2024
@DennisTraub DennisTraub self-requested a review September 9, 2024 13:58
Copy link
Collaborator

@DennisTraub DennisTraub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've updated some dependencies and the region and it's good to go.

@DennisTraub DennisTraub requested review from DennisTraub and beqqrry-aws and removed request for DennisTraub September 9, 2024 14:32
@DennisTraub DennisTraub linked an issue Sep 10, 2024 that may be closed by this pull request
@DennisTraub DennisTraub changed the title Bedrock constructor argument corrections. PHP: Bedrock constructor argument corrections. Sep 12, 2024
@DennisTraub DennisTraub force-pushed the php-sdk-quintes branch 3 times, most recently from adb5d97 to 4fa3804 Compare September 18, 2024 09:40
@meyertst-aws meyertst-aws added On Call Review complete On call review complete Bug An update to fix incorrect code or typos. labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An update to fix incorrect code or typos. PHP This issue relates to the AWS SDK for PHP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PHP Bedrock and BedrockRuntime constructor arguments
4 participants