-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP: Bedrock constructor argument corrections. #6824
Open
quintes
wants to merge
5
commits into
awsdocs:main
Choose a base branch
from
quintes:php-sdk-quintes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DennisTraub
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've updated some dependencies and the region and it's good to go.
DennisTraub
requested review from
DennisTraub and
beqqrry-aws
and removed request for
DennisTraub
September 9, 2024 14:32
DennisTraub
force-pushed
the
php-sdk-quintes
branch
from
September 10, 2024 08:41
e157522
to
67f409b
Compare
DennisTraub
force-pushed
the
php-sdk-quintes
branch
from
September 11, 2024 14:27
67f409b
to
f8c34f7
Compare
DennisTraub
changed the title
Bedrock constructor argument corrections.
PHP: Bedrock constructor argument corrections.
Sep 12, 2024
DennisTraub
force-pushed
the
php-sdk-quintes
branch
3 times, most recently
from
September 18, 2024 09:40
adb5d97
to
4fa3804
Compare
meyertst-aws
added
On Call Review complete
On call review complete
Bug
An update to fix incorrect code or typos.
labels
Oct 18, 2024
meyertst-aws
force-pushed
the
php-sdk-quintes
branch
from
October 18, 2024 13:08
4fa3804
to
8992349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP Bedrock and BedrockRuntime constructor arguments #6823 fix
This pull request will provide the correct arguments to the Bedrock and Bedrock runtime constructors for the PHP examples
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license