JavaScript (v3): SageMaker - Add afterAll hook in test to ensure cleanup on timeouts. #6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpyle0819
added
On Call Review needed
github-actions
bot
added
the
Javascript-v3
rlhagerm
approved these changes
Mar 26, 2024
rlhagerm
added
On Call Review complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is attempting to fix an edgecase in the SageMaker integration tests. I'm guessing that the test was timing out and there was no cleanup. This adds an afterAll step to the test that ensures cleanup if the tests timeout.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.