[Tools] Add service prefix to bundled examples to avoid naming collisions #6026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add full list of services back to bedrock scenario.
Laren-AWS
added
On Call Review needed
github-actions
bot
removed
the
Tools
ford-at-aws
approved these changes
Jan 31, 2024
ford-at-aws
added
On Call Review complete
max-webster
pushed a commit
to max-webster/aws-doc-sdk-examples
that referenced
this pull request
Mar 15, 2024
…ions (awsdocs#6026) * Add service prefix to bundled examples to avoid naming collisions and add full list of services back to bedrock scenario. * Fix broken links in scenario block. --------- Co-authored-by: David Souther <davidsouther+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a services are bundled (like bedrock, bedrock-runtime, etc.), you cannot list more than one service for an example in the
servicesfield of the metadata, because if you do the same example is published with the same ID in the output, which causes a naming collision.This update prefixes the example names for bundled services with the service client name so that each copy of the example has a unique ID and no collision occurs.
I've also added the full list of services back to the bedrock scenario (which was the original intent and is what uncovered this bug in the first place).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.