Shell Script: script to automate modification of EBS GP2 volumes to GP3 in EC2 service #5631
Conversation
razguru
changed the title
DavidSouther
added
the
Task
There was a problem hiding this comment.
Hi Rohit,
The PR needs to be linted, formatted and moved.
You should move it to the folder
"aws-cli/bash-linux/ec"
You should lint it with "shellcheck".
You should format it with "shfmt".
You can look at "aws-cli/bash-linux/ec2/change-ec2-instance-type" and follow their example for comments' style and testing.
I will do a more thorough review when it has been linted and formatted.
| # Author : @razguru | ||
| # Version : 1.1 - - Added cross account action through --profile assume role | ||
| # Desc : Discover or/and modify GP2 volumes with/without snapshot | ||
|
|
There was a problem hiding this comment.
The script needs the proper copyright and information about setting up and running AWS CLI.
See
| @@ -0,0 +1,248 @@ | |||
| #! /bin/bash | |||
| # Author : @razguru | |||
There was a problem hiding this comment.
Author and version should not be here.
| manual-disc() | ||
| { | ||
| if [ ! -z "$file_name" ] && [ -s "$file_name" ] ; then | ||
| /bin/cp "$file_name" "$gp2_vol_id" &> /dev/null |
There was a problem hiding this comment.
You should not use full paths for commands
| /bin/cp "$file_name" "$gp2_vol_id" &> /dev/null | |
| cp "$file_name" "$gp2_vol_id" &> /dev/null |
| io2_vol_id="$account"_"$region"_"$dt"_io2_vol_id.txt | ||
|
|
||
| gp2_vol_error="$account"_"$region"_"$dt"_gp2_vol_error.txt | ||
| /usr/bin/aws ec2 describe-volumes --region "${region}" --profile "${account}" --filters Name=volume-type,Values=gp2 > /dev/null 2> "$gp2_vol_error" |
There was a problem hiding this comment.
Again here and elsewhere, you should not use full paths
| /usr/bin/aws ec2 describe-volumes --region "${region}" --profile "${account}" --filters Name=volume-type,Values=gp2 > /dev/null 2> "$gp2_vol_error" | |
| aws ec2 describe-volumes --region "${region}" --profile "${account}" --filters Name=volume-type,Values=gp2 > /dev/null 2> "$gp2_vol_error" |
| dt=`date +%F-%T` | ||
|
|
||
| # Ensure region is provided | ||
| if [ -z $region ] || [[ $reg != --region ]] || [ -z $file_name ]; then |
There was a problem hiding this comment.
The script should have a main function.
| log=""$region"_"$dt"_vol_modification_progress.log" | ||
|
|
||
| #Ensure vol_id_list is provided | ||
| if [ -z $vol_id_list ] || [ ! -s $vol_id_list ] ; then |
There was a problem hiding this comment.
The script should have a main function.
| { | ||
| "Version": "2012-10-17", | ||
| "Statement": [ | ||
| { | ||
| "Sid": "VisualEditor0", | ||
| "Effect": "Allow", | ||
| "Action": [ | ||
| "ec2:ModifyVolume", | ||
| "ec2:DescribeVolumes", | ||
| "ec2:DescribeVolumesModifications", | ||
| "ec2:DescribeVolumeStatus", | ||
| "ec2:DescribeTags", | ||
| "ec2:CreateTags", | ||
| "ec2:DescribeRegions", | ||
| "ec2:DescribeSnapshots", | ||
| "ec2:CreateSnapshot", | ||
| ], | ||
| "Resource": "*" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
Recommended: rename file to JSON to match data type.
|
Hey @razguru ! Thank you for your contribution. Do you need any assistance with these changes requested by @meyertst-aws ? |
|
Closing this until the author has time to work on it. |
This pull request is to publish the bash scripts to automate the discovery of all EBS volume types and modify all identified GP2 volume type to GP3 with optional snapshot in any region or all regions. It can span across multiple accounts post setting IAM assume role account's profile.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.