Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET v3: SNS fix List the subscribes of a topic example. #5287

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

rlhagerm
Copy link
Contributor

This pull request fixes an issue with the .NET SNS example for "List the subscribers of a topic", which was instead listing all subscribers. Fixes a customer-reported issue and ticket.

Closes #5285


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rlhagerm rlhagerm self-assigned this Aug 21, 2023
@github-actions github-actions bot added the DotNet-v3 This issue relates to the AWS SDK for .NET V3 label Aug 21, 2023
@rlhagerm rlhagerm added On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review Bug labels Aug 21, 2023
@rlhagerm rlhagerm requested review from a team, ford-at-aws and cpyle0819 and removed request for a team and ford-at-aws August 21, 2023 15:26
@rlhagerm rlhagerm force-pushed the dotnetv3-sns-fix-list-subscriptions branch from ac40a9e to 1cf9598 Compare August 21, 2023 15:27
Copy link
Contributor

@cpyle0819 cpyle0819 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rlhagerm rlhagerm force-pushed the dotnetv3-sns-fix-list-subscriptions branch from 9f9fad7 to 59b0d14 Compare August 21, 2023 15:53
@cpyle0819 cpyle0819 added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Aug 22, 2023
@cpyle0819 cpyle0819 force-pushed the dotnetv3-sns-fix-list-subscriptions branch from 59b0d14 to fc4fa9c Compare August 22, 2023 17:32
@cpyle0819 cpyle0819 force-pushed the dotnetv3-sns-fix-list-subscriptions branch from fc4fa9c to 509bd94 Compare August 22, 2023 17:35
@cpyle0819 cpyle0819 merged commit 04d0fb7 into awsdocs:main Aug 22, 2023
7 checks passed
@rlhagerm rlhagerm deleted the dotnetv3-sns-fix-list-subscriptions branch August 25, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DotNet-v3 This issue relates to the AWS SDK for .NET V3 On Call Review complete On call review complete Text Review not needed This contains no text which needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET: add topic option to ListSubscriptionsAction
2 participants