C++: updated windows build with curl lib #5282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyertst-aws
added
C++
meyertst-aws
added
On Call Review needed
ford-at-aws
approved these changes
Aug 21, 2023
ford-at-aws
added
On Call Review complete
meyertst-aws
force-pushed
the
5252-enable-windows-build-of-c++-file-in-special-case
branch
from
c526bf4
to
207d56d
Compare
meyertst-aws
force-pushed
the
5252-enable-windows-build-of-c++-file-in-special-case
branch
from
207d56d
to
f842e7c
Compare
meyertst-aws
deleted the
5252-enable-windows-build-of-c++-file-in-special-case
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no SOS or documentation changes.
Updated some comments.
Updated CMakeLists.txt
Enabled build of list_buckets_disabling_dns_cache.cpp on windows when using curl library
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.