-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript (v3): FSA #5255
Merged
Merged
JavaScript (v3): FSA #5255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpyle0819
added
On Call Review needed
This work needs an on-call review
Text Review not needed
This contains no text which needs review
labels
Aug 14, 2023
github-actions
bot
added
the
Javascript-v3
This issue relates to the AWS SDK for Javascript V3
label
Aug 14, 2023
cpyle0819
added
Text Review needed
This work needs editorial (text) review
and removed
Text Review not needed
This contains no text which needs review
labels
Aug 14, 2023
rlhagerm
requested changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments and questions on this one.
javascriptv3/example_code/cross-services/feedback-sentiment-analyzer/ExtractText/dist/index.mjs
Outdated
Show resolved
Hide resolved
javascriptv3/example_code/cross-services/feedback-sentiment-analyzer/ExtractText/dist/index.mjs
Outdated
Show resolved
Hide resolved
...oss-services/feedback-sentiment-analyzer/ExtractText/tests/extract-text-handler.unit.test.js
Outdated
Show resolved
Hide resolved
...riptv3/example_code/cross-services/feedback-sentiment-analyzer/AnalyzeSentiment/package.json
Outdated
Show resolved
Hide resolved
javascriptv3/example_code/cross-services/feedback-sentiment-analyzer/ExtractText/src/index.js
Outdated
Show resolved
Hide resolved
javascriptv3/example_code/cross-services/feedback-sentiment-analyzer/ExtractText/src/index.js
Show resolved
Hide resolved
lkdavies
reviewed
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial comments
javascriptv3/example_code/cross-services/feedback-sentiment-analyzer/README.md
Outdated
Show resolved
Hide resolved
lkdavies
added
Text Review complete
Text review complete
and removed
Text Review needed
This work needs editorial (text) review
labels
Aug 14, 2023
meyertst-aws
approved these changes
Aug 14, 2023
rlhagerm
approved these changes
Aug 15, 2023
rlhagerm
added
On Call Review complete
On call review complete
and removed
On Call Review needed
This work needs an on-call review
labels
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Javascript-v3
This issue relates to the AWS SDK for Javascript V3
On Call Review complete
On call review complete
Text Review complete
Text review complete
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements FSA in JavaScript
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.