Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript (v3): FSA #5255

Merged
merged 11 commits into from
Aug 15, 2023
Merged

JavaScript (v3): FSA #5255

merged 11 commits into from
Aug 15, 2023

Conversation

cpyle0819
Copy link
Contributor

This pull request implements FSA in JavaScript


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819 cpyle0819 added On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review labels Aug 14, 2023
@cpyle0819 cpyle0819 requested a review from a team August 14, 2023 15:59
@cpyle0819 cpyle0819 self-assigned this Aug 14, 2023
@cpyle0819 cpyle0819 requested review from meyertst-aws and removed request for a team August 14, 2023 16:00
@github-actions github-actions bot added the Javascript-v3 This issue relates to the AWS SDK for Javascript V3 label Aug 14, 2023
@cpyle0819 cpyle0819 added Text Review needed This work needs editorial (text) review and removed Text Review not needed This contains no text which needs review labels Aug 14, 2023
Copy link
Contributor

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments and questions on this one.

Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

@lkdavies lkdavies added Text Review complete Text review complete and removed Text Review needed This work needs editorial (text) review labels Aug 14, 2023
@rlhagerm rlhagerm added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Aug 15, 2023
@rlhagerm rlhagerm merged commit ee4977b into awsdocs:main Aug 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Text Review complete Text review complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants