JavaScript (v3): Clean up secrets manager. #5221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpyle0819
added
On Call Review needed
github-actions
bot
added
the
Javascript-v3
beqqrry-aws
reviewed
Aug 9, 2023
beqqrry-aws
approved these changes
Aug 9, 2023
rlhagerm
approved these changes
Aug 9, 2023
rlhagerm
force-pushed
the
corepyle/secrets-manager-cleanup
branch
from
1eedf7f
to
4f897db
Compare
rlhagerm
added
On Call Review complete
cpyle0819
force-pushed
the
corepyle/secrets-manager-cleanup
branch
from
4f897db
to
d9ea8dc
Compare
rlhagerm
force-pushed
the
corepyle/secrets-manager-cleanup
branch
from
d9ea8dc
to
051ea8b
Compare
shepazon
pushed a commit
to shepazon/aws-doc-sdk-examples
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the secrets manager example, adds an integration test, and adds the project to the node workspace.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.