Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript (v3): Onboard some SQS guide entries into SOS. #5216

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

cpyle0819
Copy link
Contributor

This pull request onboards to SOS a handful of SQS examples that were in the JavaScript guide but not in the code library.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819 cpyle0819 added On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review labels Aug 7, 2023
@cpyle0819 cpyle0819 requested a review from a team August 7, 2023 19:38
@cpyle0819 cpyle0819 self-assigned this Aug 7, 2023
@cpyle0819 cpyle0819 requested review from scmacdon and a team and removed request for a team August 7, 2023 19:38
@github-actions github-actions bot added the Javascript-v3 This issue relates to the AWS SDK for Javascript V3 label Aug 7, 2023
@cpyle0819 cpyle0819 removed the request for review from a team August 7, 2023 19:38
Copy link
Contributor

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a couple of questions.

.doc_gen/metadata/sqs_metadata.yaml Show resolved Hide resolved
.doc_gen/metadata/sqs_metadata.yaml Show resolved Hide resolved
@rlhagerm rlhagerm force-pushed the corepyle/sqs-guide-onboarding branch from 91dd343 to 2ba8dd8 Compare August 8, 2023 20:16
@rlhagerm rlhagerm added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Aug 8, 2023
@rlhagerm rlhagerm merged commit eec49b2 into awsdocs:main Aug 8, 2023
13 checks passed
@cpyle0819 cpyle0819 deleted the corepyle/sqs-guide-onboarding branch August 9, 2023 14:15
shepazon pushed a commit to shepazon/aws-doc-sdk-examples that referenced this pull request Aug 10, 2023
* JavaScript (v3): Onboard some SQS guide entries into SOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Text Review not needed This contains no text which needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants