Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript (v3): Topics and Queues workflow #5214

Merged
merged 20 commits into from
Aug 9, 2023
Merged

JavaScript (v3): Topics and Queues workflow #5214

merged 20 commits into from
Aug 9, 2023

Conversation

cpyle0819
Copy link
Contributor

This pull request adds the Topics and Queues workflow for JavaScript.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819 cpyle0819 requested a review from a team August 7, 2023 16:40
@cpyle0819 cpyle0819 self-assigned this Aug 7, 2023
@cpyle0819 cpyle0819 requested review from meyertst-aws and removed request for a team August 7, 2023 16:40
@cpyle0819 cpyle0819 added On Call Review needed This work needs an on-call review Text Review needed This work needs editorial (text) review labels Aug 7, 2023
meyertst-aws
meyertst-aws requested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@meyertst-aws meyertst-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just one piece of metadata missing, I think

javascriptv3/example_code/sqs/actions/get-queue-attributes.js Show resolved Hide resolved
@github-actions github-actions bot added the Javascript-v3 This issue relates to the AWS SDK for Javascript V3 label Aug 7, 2023
lkdavies
lkdavies reviewed Aug 8, 2023
View reviewed changes
Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial review

javascriptv3/example_code/cross-services/wkflw-topics-queues/README.md Outdated Show resolved Hide resolved
javascriptv3/example_code/cross-services/wkflw-topics-queues/README.md Outdated Show resolved Hide resolved
@lkdavies lkdavies added Text Review complete Text review complete and removed Text Review needed This work needs editorial (text) review labels Aug 8, 2023
@cpyle0819
JavaScript (v3): Start SNS workflow.
f21e595
@cpyle0819
JavaScript (v3): Add logger to SNS workflow.
55cf9ed
@cpyle0819
JavaScript (v3): Add up to queue creation for SNS workflow.
0f8e921
@cpyle0819
JavaScript (v3): Add step to attach IAM policies to SNS workflow.
bc96425
@cpyle0819
JavaScript (v3): Add step to subscribe queues to SNS workflow.
139ca7a
@cpyle0819
JavaScript (v3): Add step to publish messages to SNS workflow.
332cbab
@cpyle0819
JavaScript (v3): Add step to receive messages to SNS workflow.
4554ba3
@cpyle0819
JavaScript (v3): Fix cleanup step in SNS workflow.
7765745
@cpyle0819
JavaScript (v3): Add test for receiving and deleting messages to SNS …
8edfad9 
…workflow.
@cpyle0819
JavaScript (v3): Add SNS subscribe queue action.
60f2e91
@cpyle0819
JavaScript (v3): Add SNS subscribe queue filtered action.
c134aa6
@cpyle0819
JavaScript (v3): Add SNS GetQueueAttributes action example.
7bf77a3
@cpyle0819
JavaScript (v3): Update SNS/SQS metadata and fix issue with non-fifo …
1e46b4f 
…flow in example.
@cpyle0819
JavaScript (v3): Fix SNS workflow metadata entry.
e3e2e4e
@cpyle0819
JavaScript (v3): Rename SNS workflow.
7425e04
@cpyle0819
JavaScript (v3): Fix bracket spacing in metadata.
3d9c4ca
@cpyle0819
JavaScript (v3): Fix missing punctuation in SQS metadata.
92ff7db
@cpyle0819
JavaScript (v3): Add GetQueueAttributes to SOS.
00a8b15
@cpyle0819 @lkdavies
Apply suggestions from code review
6411b73 
Co-authored-by: Liz Kellebrew-Davies <35241259+lkdavies@users.noreply.github.com>
@rlhagerm rlhagerm added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Aug 9, 2023
@rlhagerm rlhagerm merged commit 87a3e96 into awsdocs:main Aug 9, 2023
12 of 13 checks passed
@cpyle0819 cpyle0819 deleted the corepyle/sns-workflow branch August 10, 2023 13:16
shepazon pushed a commit to shepazon/aws-doc-sdk-examples that referenced this pull request Aug 10, 2023
@cpyle0819 @shepazon
JavaScript (v3): Topics and Queues workflow (awsdocs#5214)
f017e03 
JavaScript (v3): Topics and Queues workflow
@rlhagerm rlhagerm added Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs. Follow After Scouts, more languages are added to examples as Follows. labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkdavies lkdavies lkdavies left review comments

@meyertst-aws meyertst-aws meyertst-aws approved these changes

@rlhagerm rlhagerm rlhagerm approved these changes

Assignees

@cpyle0819 cpyle0819

Labels
Follow After Scouts, more languages are added to examples as Follows. Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Text Review complete Text review complete Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cpyle0819 @lkdavies @meyertst-aws @rlhagerm