Rust: Updated send-email.rs for Contact list with more that one contact, SES #5202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyertst-aws
requested review from
DavidSouther
and removed request for
DavidSouther
rcoh
suggested changes
Aug 7, 2023
ford-at-aws
added
On Call Review complete
DavidSouther
approved these changes
Sep 6, 2023
|
@d-ufrik This is failing the Rust linter (named Rust/Check in the actions list). Check the logs and push an update. |
cs is being returned without a comma. eg:
user@example.comuser2@example.com...
Causes Exception:
Error: BadRequestException(BadRequestException { message: Some("Illegal address"), meta: ErrorMetadata { code: Some("BadRequestException"), message: Some("Illegal address"), extras: Some({"aws_request_id": "da0bf20a-52b3-4acc-bb22-eec27cf68322"}) } })
If the contact list has more that one contact it will fail.
Fixed.
cs is being generated as String, if the Contact list has more that one contact it will fail. eg:
user@example.comuser2@example.com...
Causes Exception:
Error: BadRequestException(BadRequestException { message: Some("Illegal address"), meta: ErrorMetadata { code: Some("BadRequestException"), message: Some("Illegal address"), extras: Some({"aws_request_id": "da0bf20a-52b3-4acc-bb22-eec27cf68322"}) } })
cs is now a Vec<String> and is directly assigned to dest.to_addresses
rustfmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed.
cs is being generated as String, if the Contact list has more that one contact it will fail. eg.
it generates: user@example.comuser2@example.com ...
Causes Exception:
Error: BadRequestException(BadRequestException { message: Some("Illegal address"), meta: ErrorMetadata { code: Some("BadRequestException"), message: Some("Illegal address"), extras: Some({"aws_request_id": "da0bf20a-52b3-4acc-bb22-eec27cf68322"}) } })
cs is now a Vec and is directly assigned to dest.to_addresses
Now it sends emails to a contact list with more that one element.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.