-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript (v3): SNS - Cleanup #5174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpyle0819
added
On Call Review needed
This work needs an on-call review
Text Review not needed
This contains no text which needs review
labels
Jul 28, 2023
cpyle0819
requested review from
a team and
Laren-AWS
and removed request for
a team
July 28, 2023 14:39
Laren-AWS
requested changes
Jul 28, 2023
javascriptv3/example_code/sns/actions/check-if-phone-number-is-opted-out.js
Show resolved
Hide resolved
Laren-AWS
approved these changes
Jul 28, 2023
cpyle0819
force-pushed
the
corepyle/js-sns-workflow
branch
from
July 31, 2023 16:48
3f0db3d
to
f2cb50b
Compare
beqqrry-aws
added
On Call Review complete
On call review complete
Bug
Javascript-v3
This issue relates to the AWS SDK for Javascript V3
and removed
On Call Review needed
This work needs an on-call review
labels
Jul 31, 2023
beqqrry-aws
force-pushed
the
corepyle/js-sns-workflow
branch
from
July 31, 2023 22:41
f2cb50b
to
648f8d5
Compare
shepazon
pushed a commit
to shepazon/aws-doc-sdk-examples
that referenced
this pull request
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Javascript-v3
This issue relates to the AWS SDK for Javascript V3
On Call Review complete
On call review complete
Text Review not needed
This contains no text which needs review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and reorganizes the SNS code examples.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.