Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: RDS get started with instances scenario #5030

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Go: RDS get started with instances scenario #5030

merged 2 commits into from
Jul 11, 2023

Conversation

Laren-AWS
Copy link
Contributor

Go implementation of the RDS Get started with instances scenario: #3389.

  • Hello RDS
  • Get started with instances
  • Unit and integration tests
  • SOS metadata
  • README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Laren-AWS Laren-AWS self-assigned this Jul 5, 2023
@github-actions github-actions bot added the Go-v2 label Jul 5, 2023
rlhagerm
rlhagerm requested changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@rlhagerm rlhagerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small comments and questions, looks good.

gov2/rds/actions/instances.go Show resolved Hide resolved
gov2/rds/actions/instances.go Outdated Show resolved Hide resolved
gov2/rds/actions/instances.go Show resolved Hide resolved
.doc_gen/metadata/rds_metadata.yaml Outdated Show resolved Hide resolved
lkdavies
lkdavies reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

gov2/rds/scenarios/get_started_instances.go Outdated Show resolved Hide resolved
gov2/rds/scenarios/get_started_instances.go Outdated Show resolved Hide resolved
gov2/rds/scenarios/get_started_instances.go Outdated Show resolved Hide resolved
gov2/rds/scenarios/get_started_instances.go Outdated Show resolved Hide resolved
gov2/rds/scenarios/get_started_instances.go Outdated Show resolved Hide resolved
gov2/rds/scenarios/get_started_instances.go Outdated Show resolved Hide resolved
@Laren-AWS Laren-AWS requested a review from cpyle0819 July 7, 2023 19:22
@cpyle0819
Copy link
Contributor

@Laren-AWS
Screenshot 2023-07-07 at 4 01 56 PM

Laren-AWS and others added 2 commits July 11, 2023 14:50
@Laren-AWS @scmacdon
Go implementation of RDS get started with instances scenario and related
26274b4 
actions.
* Hello RDS
* Get started with instances
* Unit and integration tests
* SOS metadata
* README
@Laren-AWS @rlhagerm
@lkdavies @scmacdon
Apply suggestions from code review
9e3246a 
Co-authored-by: Rachel Hagerman <110480692+rlhagerm@users.noreply.github.com>
Co-authored-by: Liz Kellebrew-Davies <35241259+lkdavies@users.noreply.github.com>
@scmacdon scmacdon merged commit 6476a9e into awsdocs:main Jul 11, 2023
8 checks passed
@Laren-AWS Laren-AWS deleted the go-rds-mvp branch June 10, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkdavies lkdavies lkdavies left review comments

@cpyle0819 cpyle0819 cpyle0819 approved these changes

@rlhagerm rlhagerm rlhagerm approved these changes

Assignees

@Laren-AWS Laren-AWS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Laren-AWS @cpyle0819 @lkdavies @rlhagerm @scmacdon