-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java V2: Add examples for uploading a stream of unkown size in S3 #5019
Conversation
Cloud desktop site for PR review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial comments
javav2/example_code/s3/src/main/java/com/example/s3/async/PutObjectFromStreamAsync.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/async/PutObjectFromStreamAsync.java
Outdated
Show resolved
Hide resolved
javav2/example_code/s3/src/main/java/com/example/s3/transfermanager/UploadStream.java
Outdated
Show resolved
Hide resolved
Needs Scott's review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just one question, and I agree that Scott should officially approve.
…ading to S3 from a stream of unknown size. https://issues.amazon.com/issues/V932115696
This PR provides 2 code examples (with tests) that show how to upload an object from a stream of unknown size. Once example uses the JavaV2 S3 Transfer Manager and one example uses the CRT-based S3 Client (async).
Dependencies updates as well.
This pull request...
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.