Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java V2: Add examples for uploading a stream of unkown size in S3 #5019

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Java V2: Add examples for uploading a stream of unkown size in S3 #5019

merged 5 commits into from
Jul 11, 2023

Conversation

tkhill-AWS
Copy link
Collaborator

This PR provides 2 code examples (with tests) that show how to upload an object from a stream of unknown size. Once example uses the JavaV2 S3 Transfer Manager and one example uses the CRT-based S3 Client (async).

Dependencies updates as well.

This pull request...


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tkhill-AWS
Copy link
Collaborator Author

Cloud desktop site for PR review.

@rlhagerm rlhagerm requested a review from scmacdon July 3, 2023 16:52
@rlhagerm rlhagerm requested a review from a team July 3, 2023 17:53
@rlhagerm rlhagerm changed the title Add examples for uploading a stream of unkown size Java V2: Add examples for uploading a stream of unkown size in S3 Jul 3, 2023
@rlhagerm rlhagerm requested review from a team and Laren-AWS and removed request for scmacdon and a team July 3, 2023 17:54
Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

@cpyle0819
Copy link
Contributor

Needs Scott's review.

Copy link
Contributor

@Laren-AWS Laren-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one question, and I agree that Scott should officially approve.

javav2/example_code/s3/pom.xml Show resolved Hide resolved
@scmacdon scmacdon merged commit 4085849 into awsdocs:main Jul 11, 2023
7 checks passed
@tkhill-AWS tkhill-AWS deleted the s3tm_upload_stream branch July 20, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants