Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for Calico operator #341

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

caseydavenport
Copy link
Contributor

Issue #, if available:

Description of changes:

This is a documentation PR that corresponds with the following changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

@tmjd tmjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change needed but otherwise LGTM.


```
curl -o calico.yaml https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/v1.7.5/config/v1.7/calico.yaml
curl -o calico-operator.yaml https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/v1.7.5/config/v1.7/calico-operator.yaml
curl -o calico-crs.yaml https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/v1.7.5/config/v1.7/calico-operator.yaml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was suppose to be calico-crs.yaml.

@jimdial-aws
Copy link
Contributor

I get 404 errors for all the new links in this PR.

@caseydavenport
Copy link
Contributor Author

I get 404 errors for all the new links in this PR.

@jimdial-aws Yeah, I'm not sure how to order these, so would appreciate guidance on what the right process is. This PR depends on the changes in this one: aws/amazon-vpc-cni-k8s#1410

I think the links probably need to be updated for the next release (v1.8?). The changes in that PR (1410) are against master.

@jimdial-aws
Copy link
Contributor

@caseydavenport Once the other PR changes are merged and these links are live, I'll look at merging this again. Thanks.

@jayanthvn
Copy link
Contributor

I have merged this aws/amazon-vpc-cni-k8s#1410 to master.

@caseydavenport
Copy link
Contributor Author

Thanks @jayanthvn!

Is there a way to make this docs update in such a way that it will go live with the next release from master (v1.8)?

@jimdial-aws
Copy link
Contributor

I'll watch for the change to go live and try to make the docs change as soon as possible, but it may not be until Monday, depending on when the change goes live.

@jimdial-aws jimdial-aws merged commit 5a3485b into awsdocs:master Apr 2, 2021
@jimdial-aws
Copy link
Contributor

Thank you for your submission!

@caseydavenport caseydavenport deleted the casey-operator branch April 2, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants