codegen: Update SDK clients to use utilities for joining URL Path and RawQuery #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
reviewed
Mar 30, 2021
This was referenced Mar 30, 2021
jasdel
force-pushed
the
jasdel/fixup/URLPath
branch
from
f95013c to
3b92f54
Compare
skmcgrail
approved these changes
Mar 30, 2021
skotambkar
approved these changes
Mar 31, 2021
...rc/main/java/software/amazon/smithy/go/codegen/integration/HttpBindingProtocolGenerator.java
Show resolved
Hide resolved
jasdel
added a commit
to aws/aws-sdk-go-v2
that referenced
this pull request
Mar 31, 2021
Fixes the API clients to not ignore the resolved endpoint's URL Path and RawQuery parameters. Instead of ignoring the values the SDK will append the operation's modeled Path and Query String. Fixes #1191 Depends on aws/smithy-go#280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Smithy SDK client httpbinding serializers to use the JoinPath and JoinRawQuery utilities to ensure paths and query are joined correctly.
Related to # aws/aws-sdk-go-v2#1191