Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean and Number shapes can be decorated as boxed or unboxed #127

Closed
jasdel opened this issue Aug 5, 2020 · 0 comments · Fixed by #232
Closed

Boolean and Number shapes can be decorated as boxed or unboxed #127

jasdel opened this issue Aug 5, 2020 · 0 comments · Fixed by #232
Labels
refactor
Milestone
v1.0 Release Cand...

Comments

@jasdel
Copy link
Contributor

jasdel commented Aug 5, 2020

The generator should support generating boolean and number shapes as both boxed and unboxed. This would prevent the need to generate members of these shapes being rendered as pointers, and can be values instead.

https://awslabs.github.io/smithy/1.0/spec/core/model.html?highlight=boolean#default-values
This was referenced Nov 11, 2020
Merged
Closed
@jasdel jasdel added this to the v1.0 Release Candidate milestone Nov 13, 2020
jasdel added a commit that referenced this issue Nov 15, 2020
@jasdel
codegen: Introduce the concept of a NullableIndex and Pointable Index (…
7f45e6a 
…#232)

Adds a new KnowedgeIndex implementation GoPointableIndex this index declares when a shape should be a pointer or value type in Go code. Updates the SDK's code generation so that all non-sparse list and maps are rendered with value members instead of pointers. This null-ability applies to number and boolean members to that are not explicitly decorated as boxed.

Fixes #128
Fixes #127
Fixes #149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
v1.0 Release Candidate
Development

Successfully merging a pull request may close this issue.

codegen: Introduce the concept of a NullableIndex and Pointable Index jasdel/smithy-go
1 participant
@jasdel