fix: reuse AsyncInitializationWrapper in SpringDelegatingLambdaContainerHandler #883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#758
Description of changes:
Did some testing with this app https://github.com/aws-samples/aws-lambda-java-workshop/tree/main/labs/unicorn-store/software/unicorn-store-spring and 512 MB memory.
Comparison between
old
StreamLambdaHandler
implementation: Duration: 648.79 ms Billed Duration: 649 ms Memory Size: 1024 MB Max Memory Used: 333 MB Init Duration: 9747.09 msand
new
SpringDelegatingLambdaContainerHandler
Duration: 16626.82 ms Billed Duration: 16627 ms Memory Size: 1024 MB Max Memory Used: 330 MB Init Duration: 1344.65 msWith this change the init is done properly. Threading still needs to be removed from SCF.
By submitting this pull request