-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpringDelegatingLambdaContainerHandler seems does not work with query parameters #754
Comments
While concentrating on REST we somehow ignored standard request parameters. This fix addresses it for both v1 and v2 requests as well as adds tests and additional endpoint to a sample to verify Resolves aws#754
While concentrating on REST we somehow ignored standard request parameters. This fix addresses it for both v1 and v2 requests as well as adds tests and additional endpoint to a sample to verify Resolves aws#754 polishing
Hey guys, how may I include this fix in maven? Which version to use? |
It will be 2.0.0 but it's not released yet (likely beginning of next week). |
Thanks, will it be a new version like -M3? |
No it will be the stable release without a milestone. |
You can clone the repo and build from source if you want to validate the fix now. |
Yes but my question was - if I will wait for release on the next seek, will it be publicly available in maven central, etc? |
Yes, 2.0.0 will be also available on Maven Central. |
Thank you |
Hello to everyone.
Spring boot 3.1.0
aws-serverless-java-container-springboot3:2.0.0-M2
Frontend service: ALB, API_GW, Functional URL
Deployment method: terraform or manual
Scenario
I want my java lambda microservice to process all types of events without additional expenses: ALB, API_GW, HTTP, Functional URL
Expected behavior
Behave the same way to all event types listed above
Actual behavior
When I use SpringDelegatingLambdaContainerHandler, I get error 400 every time I have query parameters for ALB event. if I use functional url event, I get internal server error.
Steps to reproduce
@RequestMapping(path = "/w6/test/{uuid}/refresh", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_VALUE) public ResponseEntity<TMaxmindResponse> refresh( @Parameter(description = "UUID of the order") @PathVariable("uuid") String uuid, @Parameter(description = "ID of the order(primary key)") @RequestParam("order_id") Long orderId, @Parameter(description = "tab") @RequestParam("tab") String tab )
Full log output
I tried to wrap my head around it for 2 or 3 days, and found that when it tries to do
mvc.service(httpServletRequest, httpServletResponse);
it fails to error 400, no matter which parameters are. Also, if method parameters marked as optional, it returns exception and error 500, for instance,
@RequestParam("order_id") Optional<Long> orderId,
After spending that much time, I decided that this is a bug and I really appreciate if this bug is resolved ASAP. Thanks
The text was updated successfully, but these errors were encountered: