-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Input transformer for AWS::Serverless::Function.EventBridgeRule #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorRobertson
changed the title
feat: Input transformer for AWS::Serverless::Function
feat: Input transformer for AWS::Serverless::Function.EventBridgeRule
Aug 1, 2023
ConnorRobertson
commented
Aug 1, 2023
hawflau
reviewed
Aug 1, 2023
ssenchenko
approved these changes
Aug 1, 2023
awood45
requested changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good (assuming we've also done an end to end deployed test with our test template) but let's make sure to add documentation.
aaythapa
reviewed
Aug 2, 2023
samtranslator/internal/schema_source/aws_serverless_function.py
Outdated
Show resolved
Hide resolved
aaythapa
approved these changes
Aug 2, 2023
awood45
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
#2666
Description of changes
Adding Input Transformer property to AWS::Serverless::Function.EventBridgeRule
Description of how you validated changes
Transformed a template that contains Input Transformer in an EventBridgeRule. Then deployed the template.
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam init
through aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.