Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version fix vector #11

Merged
merged 3 commits into from
Dec 28, 2020

Conversation

himanishk
Copy link
Contributor

@himanishk himanishk commented Mar 2, 2020

Issue #, if available: #3

Description of changes: Fix to allow vectors as input struct. Applicable for passing input data to models like Spark Logistic Regression. Spark only supports Double types in vector type, this code enforces the double type check for inputs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@timf-bonobos
Copy link

Hi, could we have this merged into master - as this has caused us some issues recently.

Copy link
Contributor

@mahithsuresh mahithsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't use * imports. I'll follow up with another commit to rectify that. Since unit tests are passing, merging the changes here. I will revert the changes if integration tests fail in our internal pipelines.

@mahithsuresh mahithsuresh merged commit 884f066 into aws:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants