Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move sagemaker-mlflow to extras #4903

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ryansteakley
Copy link
Contributor

Issue #, if available:
#4885
Description of changes:
move sagemaker-mlflow to extras
Testing done:
pip install sagemaker
pip install sagemaker[sagemaker-mlflow]

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ x] I have read the CONTRIBUTING doc
  • [x ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [x ] I used the commit message format described in CONTRIBUTING
  • [ x] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [ x] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@benieric
Copy link
Contributor

  File "<string>", line 1, in <module>
  File "/.pyenv/versions/3.8.18/lib/python3.8/site-packages/sagemaker/__init__.py", line 18, in <module>
    from sagemaker import estimator, parameter, tuner  # noqa: F401
  File "/.pyenv/versions/3.8.18/lib/python3.8/site-packages/sagemaker/estimator.py", line 110, in <module>
    from sagemaker.mlflow.forward_sagemaker_metrics import log_sagemaker_job_to_mlflow
  File "/.pyenv/versions/3.8.18/lib/python3.8/site-packages/sagemaker/mlflow/forward_sagemaker_metrics.py", line 23, in <module>
    import mlflow
ModuleNotFoundError: No module named 'mlflow'

This should be handled gracefully so importing estimator does not fail if sagemaker-mlflow is not installed

@benieric
Copy link
Contributor

in the sagemaker/mlflow/forward_sagemaker_metrics.py we can raise custom import error warning user to install pip install sagemaker[sagemaker-mlflow] if they want to use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants