Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Adding integ tests back to integv2 #5054

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

maddeleine
Copy link
Contributor

Release Summary:

Resolved issues:

N/A

Description of changes:

We need to add all integ tests to this buildspec. Currently nix doesn't work with awslc-fips and without these tests we are missing coverage.

Call-outs:

I expect these tests will be removed once nix works with awslc-fips.

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maddeleine maddeleine requested a review from dougch as a code owner January 22, 2025 19:46
@maddeleine maddeleine requested a review from lrstewart January 22, 2025 19:46
@github-actions github-actions bot added the s2n-core team label Jan 22, 2025
Copy link
Contributor

@lrstewart lrstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have "tests" in parentheses in your title. "ci" might also be more accurate, idk.

codebuild/spec/buildspec_ubuntu_integrationv2.yml Outdated Show resolved Hide resolved
@maddeleine maddeleine changed the title (tests): Adding integ tests back to integv2 ci: Adding integ tests back to integv2 Jan 22, 2025
@maddeleine maddeleine enabled auto-merge January 22, 2025 22:43
@maddeleine maddeleine disabled auto-merge January 22, 2025 22:43
Copy link
Contributor

@lrstewart lrstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open an issue to add the client auth test back once it's fixed for openssl-1.0.2

@maddeleine maddeleine added this pull request to the merge queue Jan 23, 2025
Merged via the queue into aws:main with commit cfec910 Jan 23, 2025
44 checks passed
@maddeleine maddeleine deleted the buildspec_fix branch January 23, 2025 21:09
CarolYeh910 pushed a commit to CarolYeh910/s2n-tls that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants