chore: bump osx Openssl to latest #5041
Merged
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <rui@chenrui.dev>
boquan-fang
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Can you add some context for why we are bumping the version for OSX Openssl? The issue mentioned in the PR description didn't explain that.
lrstewart
approved these changes
Jan 17, 2025
| OPENSSL_1_1_1_INSTALL_DIR="${BREWINSTLLPATH:-"/usr/local/Cellar/openssl@1.1/1.1.1?"}" | ||
| BREWINSTLLPATH=$(brew --prefix openssl@3) | ||
| OPENSSL_3_INSTALL_DIR="${BREWINSTLLPATH:-"/opt/homebrew/Cellar/openssl@3"}" |
There was a problem hiding this comment.
I wonder if this should just be OPENSSL_INSTALL_DIR or even LIBCRYPTO_INSTALL_DIR so we never have to update all the references again. But I don't think we plan to test awslc here, and we've probably got a while before openssl-4 :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
none
Description of changes:
Bump the version of Openssl we test on OSX to 3.4 (latest) from EOL 1.1.1.
Call-outs:
Based on discussions from #5010 - only add 3.4 to the version check test.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.