feat(s2n-tls-hyper): Allow plain HTTP connections #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
force-pushed
the
insecure-http
branch
from
2cf6727 to
00f3218
Compare
Co-authored-by: Wesley Rosenblum <55108558+WesleyRosenblum@users.noreply.github.com>
WesleyRosenblum
approved these changes
Dec 16, 2024
jmayclin
approved these changes
Dec 17, 2024
| } | ||
|
|
||
| impl<Http, ConnBuilder> Builder<Http, ConnBuilder> { | ||
| /// If enabled, allows communication with insecure HTTP endpoints in addition to secure HTTPS endpoints (default: false). | ||
| pub fn with_insecure_http(&mut self, enabled: bool) -> &mut Self { |
There was a problem hiding this comment.
Thought: is insecure too strong a word for this? Maybe something like with_plaintext_http would be a bit more ambivalent.
Although I guess if you're going through the trouble of using the s2n-tls-hyper connector, plaintext http is a little sus. I don't think the current naming was bad, just curious about reasoning.
There was a problem hiding this comment.
Yeah insecure was meant less as a warning and more to differentiate from "secure" in HTTPS. So with_plaintext_http works just as well if that makes the meaning more clear.
jmayclin
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, an
HttpsConnectorcan only be used to make secure HTTPS requests over TLS. If communication with an insecure HTTP endpoint is attempted, anInvalidSchemeerror is returned. This behavior prevents accidentally bypassing TLS if an insecure endpoint is provided.However, this behavior may be desirable in some circumstances, if communication with both HTTPS and HTTP endpoints is required. This PR allows an
HttpsConnectorto be constructed with aninsecure_httpoption, allowing for HTTP over plain TCP to be communicated if an HTTP route is provided.Call-outs:
Previously we were erroring for HTTP schemes but permitting all other schemes (not just HTTPS). This was changed to now error for all unexpected schemes.
Is
with_insecure_httpa good name for the API? Other possible options:with_https_or_http(the equivalent hyper-rustls API)with_httpTesting:
Added a new localhost plain TCP HTTP test, which ensures that TLS is successfully bypassed, and that the plain HTTP option is disabled by default.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.