test: remove load system certs functionality for s2n_default_tls13_config #4897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmayclin
reviewed
Nov 18, 2024
| @@ -67,8 +64,13 @@ int s2n_fuzz_test(const uint8_t *buf, size_t len) | |||
| POSIX_GUARD(s2n_stuffer_alloc(&fuzz_stuffer, len)); | |||
| POSIX_GUARD(s2n_stuffer_write_bytes(&fuzz_stuffer, buf, len)); | |||
|
|
|||
| DEFER_CLEANUP(struct s2n_config *config = s2n_config_new(), s2n_config_ptr_free); | |||
| EXPECT_NOT_NULL(config); | |||
| POSIX_GUARD(s2n_config_set_cipher_preferences(config, "20240503")); | |||
There was a problem hiding this comment.
Yay for simplicity! The old function definitely seems a bit tricky.
It seems like there are two things the old function was doing, which were presumably important for some reason
- enabling TLS 1.3
- loading system certs
Can we call those out (+ why) in a comment here?
maddeleine
reviewed
Nov 18, 2024
jmayclin
approved these changes
Nov 19, 2024
maddeleine
approved these changes
Nov 19, 2024
camshaft
approved these changes
Nov 19, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
#4765
Description of changes:
I noticed that
s2n_config_testing_defaults_init_tls13_certswas only being called from a single fuzz test and could be deleted if we pinned the test to use a new config with the same security policy (20240503is the currentdefault_tls13).Testing:
This PR refactors the fuzz test, which should continue to pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.