Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fixes for cargo audit #4895

Merged
merged 3 commits into from
Nov 18, 2024
Merged

ci: fixes for cargo audit #4895

merged 3 commits into from
Nov 18, 2024

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Nov 13, 2024

Release Summary:

Resolved issues:

none

Description of changes:

S2n-tls isn't a pure rust project, more work is required before running the cargo audit action.

Call-outs:

Validated on main of my fork and again after removing the nightly cargo pin

Due to permissions issues, this action does not run in the PR workflow (hence the missed failure)

Testing:

How is this change tested: locally and in my fork

  • Any change to the CI or tests should:
    1. see my fork
    2. The action is currently failing because there is no Cargo.lock in the root directory of the project.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Nov 13, 2024
@dougch dougch marked this pull request as ready for review November 13, 2024 23:33
@dougch dougch requested review from goatgoose and camshaft November 13, 2024 23:34
@dougch dougch requested a review from goatgoose November 18, 2024 19:36
@dougch dougch enabled auto-merge (squash) November 18, 2024 19:54
@dougch dougch merged commit 535af43 into aws:main Nov 18, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants