chore: broaden use of flaky mark #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
None
Description of changes:
In #4558, I discovered that aarch64 runs of some tests under nix were flaky. With expanding Nix test runs, we're now seeing the same flakiness on x86. This PR removes the arch specific retries on some tests, and more evenly marks tests as flaky.
Call-outs:
The underlying issue remains: the way we are using stdout/stderr to watch for flags is not foolproof. On flaky tests, we see the "long running tests" are hitting the timeout value and are being killed by pytest.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.