Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix incorrect README references #4863

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

jouho
Copy link
Contributor

@jouho jouho commented Oct 30, 2024

Resolved issues:

We should fix the following items.

  • remove the reference to 6,000 lines of code
  • remove the reference to “unsupported session renegotiation”

Description of changes:

  • Removed "6,000 lines of code" reference. I could put updated number but the number will be changing so I'm voting to simply remove it.
  • Fixed documentations around session renegotiation. My understanding is that session renegotiation is now supported for s2n-tls clients, but not for s2n-tls servers based on this comment:
    * @note Calling this method on a server connection will fail. s2n-tls servers do not support renegotiation.

Call-outs:

Testing:

This is a documentation update.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Oct 30, 2024
@jouho jouho marked this pull request as ready for review October 30, 2024 00:31
compliance/specs/exceptions/rfc5746/4.4.toml Outdated Show resolved Hide resolved
crypto/s2n_sequence.c Outdated Show resolved Hide resolved
jouho added 3 commits October 30, 2024 16:42
- revert incorrect doc fix
- clang format
@jouho jouho requested a review from lrstewart October 30, 2024 17:12
crypto/s2n_sequence.c Outdated Show resolved Hide resolved
@jouho jouho requested a review from lrstewart October 30, 2024 22:09
@jouho jouho enabled auto-merge (squash) November 1, 2024 16:26
@jouho jouho merged commit 19859ef into aws:main Nov 1, 2024
37 checks passed
@jouho jouho deleted the fix-incorrect-readme-references branch November 1, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants