Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix failing OIDC workflows; cleanup unused actions #4848

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Oct 16, 2024

Description of changes:

Fix the actions with missing permissions from #4839 (not required workflows).

This PR also cleans up two unused actions that were setup to use the long term credentials.

Call-outs:

Minus the duvet change, this is the last OIDC related PR for s2n-tls.

Bindings failures will need #4849 merged first.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dougch dougch requested a review from maddeleine October 16, 2024 18:23
@github-actions github-actions bot added the s2n-core team label Oct 16, 2024
@dougch dougch requested a review from goatgoose October 16, 2024 18:28
@dougch dougch marked this pull request as ready for review October 16, 2024 18:52
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove .github/gha_monitor at some point if this is the only thing using it?

@maddeleine maddeleine merged commit ae74eb5 into aws:main Oct 18, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants