Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds print statements to help debug s2n_dynamic_load_test #4836

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

maddeleine
Copy link
Contributor

Resolved issues:

N/A

Description of changes:

The dynamic load test is difficult to debug because it has none of our normal error output. Here I add print statements for each error so that if something does go wrong, we minimally know where in s2n the error occurs. This requires loading in two s2n error helper functions.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maddeleine maddeleine requested a review from dougch as a code owner October 10, 2024 17:59
@github-actions github-actions bot added the s2n-core team label Oct 10, 2024
@maddeleine maddeleine requested a review from goatgoose October 10, 2024 18:11
Copy link
Contributor

@dougch dougch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stunning lack of output previously, thanks

@maddeleine maddeleine enabled auto-merge (squash) October 10, 2024 22:03
@maddeleine maddeleine merged commit 6dadf04 into main Oct 11, 2024
40 of 41 checks passed
@maddeleine maddeleine deleted the dl_debug branch October 11, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants