Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use newer version of libFuzzer #4762

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Conversation

jouho
Copy link
Contributor

@jouho jouho commented Sep 10, 2024

Resolved issues:

Part of #4748

We are currently manually linking a specific version of libFuzzer that is 7 years old.

git clone https://chromium.googlesource.com/chromium/llvm-project/llvm/lib/Fuzzer
cd Fuzzer
git checkout 651ead

Instead, we should use the newer version of libFuzzer that comes with clang.

Description of changes:

By using -fsanitize=fuzzer, we automatically link the libFuzzer that comes with clang. This change removes the need to manually install or link the old library against our test executables. This will also make it easier to run fuzz tests locally since we no longer need to install libFuzzer.

Testing:

Running FuzzBatch passed all test cases. Link to CodeBuild job

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Sep 10, 2024
@jouho jouho marked this pull request as ready for review September 10, 2024 18:01
@jouho jouho requested a review from dougch as a code owner September 10, 2024 18:01
@jouho jouho requested a review from maddeleine September 10, 2024 18:01
Copy link
Contributor

@dougch dougch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jouho jouho enabled auto-merge (squash) September 10, 2024 22:26
@jouho jouho merged commit 341a69e into aws:main Sep 11, 2024
36 checks passed
@jouho jouho deleted the use-clang-libfuzzer branch September 11, 2024 16:31
@jouho jouho mentioned this pull request Sep 11, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants