tests(pcap): fix support for older tshark versions #4744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #4741
Description of changes:
Fix two issues:
I also made the build script sanity check that the tshark version is compatible with the features selected.
Call-outs:
Alternatively, we could just decide that the pcap tests don't support older wiresharks / older environments like Ubuntu18 and not feature gate anything. The build could just fail if tshark is too old.
Testing:
I tested manually on my ubuntu18 instance, which has wireshark 3.6.2 and can repro all these problems. I'm not convinced that it's worth adding an ubuntu18 pcap test job to the CI, but I'm very interested in other opinions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.