ci: enable UBSAN check in ci #4734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create buildspec_address_sanitizer.yml to create build batch for both UBSAN and ASAN check. * create buildspec_ubsan.yml to specify build check process.
goatgoose
reviewed
Aug 27, 2024
* clarify comments to make them previous and to locate them in appropriate locations. * change file name for address_sanitizer to sanitizer, so that it reflects the purpose of this file.
goatgoose
approved these changes
Aug 27, 2024
* Move comments for complier to buildspec_sanitizer.yml. * Fix a typo in UBSAN file.
lrstewart
reviewed
Aug 27, 2024
There was a problem hiding this comment.
From my understanding, this is the real replacement for buildspec_asan.yml, while buildspec_new_asan.yml is basically just something new that happens to have the same name. How can you prove that you're covering all the same cases that buildspec_asan.yml currently covers, and that no test cases will be lost in the transition? This PR doesn't really diff anything with our current state, which makes it very difficult to reliably review.
I'm also not convinced that you can't just delete buildspec_asan.yml immediately. What additional testing do you plan to do before deleting it?
|
Replace this PR with PR#4740. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Enable UBSAN check for build batch CI. Resolve requirement 2 of #4684.
Description of changes:
Call-outs:
buildspec_asan.ymlbuild after everything is tested out.buildspec_new_asan.yml.https://us-west-2.codebuild.aws.amazon.com/project/eyJlbmNyeXB0ZWREYXRhIjoiZUNRMGVsWlRzOEZndkRTUHZ6Vk93Mlp1cnJYQzJBOUVDRHdaN1ZSNDE1RktMNjNIWHNYQVkwU01sdnBodWJVRW91ZDlqZzBlWUNRZGdQVGt6cEJvangxWEYwdzFBbXVVT00xMWJUb0Q4UHdsIiwiaXZQYXJhbWV0ZXJTcGVjIjoiWFQvNll0cFZOdmVsWGdVSyIsIm1hdGVyaWFsU2V0U2VyaWFsIjoxfQ%3D%3D/batch/532ce176-477e-46be-a5cd-0c39f87aff10
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.