chore: improve test coverage for rc4.is_available() #4682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this PR because it is going to result in a mess of if/defs based on the underlying libcrypto capabilities, and at this point I don't think the utility is worth it for a small increase in test coverage for a utility method for a deprecated algorithm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
#4438 was a little tedious to reproduce because the problematic method wasn't getting called with the newer libcrypto that I have on my dev instance.
This change ensure that the
rc4.is_availablemethod will have test coverage regardless of libcrypto version.Testing:
All CI should pass
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.