Adopt CBMC 6.1 and cbmc-viewer 3.9 #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fail Signed-off-by: Rod Chapman <rodchap@amazon.com>
…bject_bits option for goto-cc 6.0.0 Signed-off-by: Rod Chapman <rodchap@amazon.com>
…o keep it. Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
…n CBMC runs Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
…pto_is_awslc.c Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
…acOS. Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
…ess. Signed-off-by: Rod Chapman <rodchap@amazon.com>
…0 and beyond Signed-off-by: Rod Chapman <rodchap@amazon.com>
…l for CBMC verification Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
…nce. Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
tautschnig
approved these changes
Jul 24, 2024
Signed-off-by: Rod Chapman <rodchap@amazon.com>
1. Add comment and reference to explain why we disable standard checks when generating coverage info. 2. Remove redundant and commented-out line setting --object-bits flag Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
lrstewart
reviewed
Jul 29, 2024
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
Signed-off-by: Rod Chapman <rodchap@amazon.com>
…e-visited in a separate Issue Signed-off-by: Rod Chapman <rodchap@amazon.com>
lrstewart
reviewed
Jul 31, 2024
lrstewart
approved these changes
Jul 31, 2024
jmayclin
approved these changes
Aug 1, 2024
Signed-off-by: Rod Chapman <rodchap@amazon.com>
auto-merge was automatically disabled
August 2, 2024 09:30
Head branch was pushed to by a user without write access
Signed-off-by: Ubuntu <ubuntu@ip-172-31-46-247.eu-west-2.compute.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updates Makefiles, CI runner scripts and code to adopt newly released CBMC 6.1 and cbmc-viewer 3.9
All proofs now run OK on EC2 c7i instance AND locally on Apple M1-based macOS.
Testing:
All tests re-run on this branch on both EC2 c7i instance and M1 macOS.
macOS users - just "brew update" and "brew upgrade cbmc cbmc-viewer" to get new tool versions,
then
does the trick, but substitute "8" for the number of CPU cores on your platform (e.g. 32 for c7i.8xlarge)
Proofs should complete in about 12 minutes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.