refactor: move stuffer hex methods out of testlib #4653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We need to be able to read / write hex for JA4. In this change, I take the testlib/s2n_stuffer_hex.c methods and clean them up for non-test use:
Call-outs:
This PR doesn't include the CBMC proofs we need for stuffer methods. It was already pretty large, so I'll put the proofs in a follow-up PR. I've written them, and they're passing locally.
Testing:
I also rewrote the tests. I didn't think the existing tests were clear enough about what was being tested, and there weren't enough known-value tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.