Refactor: change set/get_decryption_key return type to S2N_RESULT in s2n_cipher struct #4638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Part of #3983
Description of changes:
set_decryption_key
andget_decryption_key
from int to S2N_RESULTs2n-tls/crypto/s2n_cipher.h
Lines 87 to 88 in d538d0a
S2N_SUCCESS
toS2N_OK
,POSIX_GUARD
toPOSIX_GUARD_RESULT
, and etc.Call-outs:
Testing:
Confirmed all unit tests pass. Will address any failures in CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.