refactor(bindings/s2n-tls): finish test harness refactor #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I missed the tests hiding behind the conditional flag
jmayclin
commented
Jul 1, 2024
|
|
||
| let pair = poll_tls_pair(pair); | ||
| let server_conn = pair.server.0.connection(); | ||
| let client_conn = pair.server.0.connection(); |
There was a problem hiding this comment.
There was a copy-paste mistake in this test. The client_hello method is not available for client connections, which is a property of the underlying C implementation. This never would have worked, and the client assertion is removed in the new version.
goatgoose
approved these changes
Jul 4, 2024
Co-authored-by: Sam Clark <3758302+goatgoose@users.noreply.github.com>
lrstewart
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
resumption.rs,pkey.rs, and recent tests ins2n_tls.rsto use the new test harnessTesting:
All tests should pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.