Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(nix): Startup/configure apache for renegotiate test under nix #4592
ci(nix): Startup/configure apache for renegotiate test under nix #4592
Changes from 24 commits
cd8f596
f69b10b
c78a311
58dad41
da4261c
afca602
7c486cc
e09b8ff
052152a
9c6baea
09940cb
5549e13
6ad3101
846751c
5c82928
8933245
bfc80e8
0f32b33
a159c2a
aae0495
bb85900
993f670
0e187d6
6e0e3f7
fd8406d
463ac52
4a7a170
79c09a9
dc29f51
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea what most of these character sets are, but since we now only support english (and spanish?), why include the obviously non-english ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trimmed it down some more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this configuration needed? How does it interact with the site-specific configuration?
s2n-tls/codebuild/bin/apache2/sites-enabled/renegotiate.conf
Lines 33 to 37 in aacb0ab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should only apply to the
*:443/
default site