Add s2n_signature_preferences_20240521 #4565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
approved these changes
May 21, 2024
jmayclin
reviewed
May 22, 2024
| &s2n_rsa_pkcs1_sha256, | ||
| &s2n_rsa_pkcs1_sha384, | ||
| &s2n_rsa_pkcs1_sha512, | ||
| &s2n_rsa_pkcs1_sha224, |
There was a problem hiding this comment.
Just want to confirm that leaving RSA+224 in is intentional?
There was a problem hiding this comment.
waffled on this, decided to keep it since the likelihood of usage is ~slightly higher than ECDSA+SHA224.
jmayclin
approved these changes
May 22, 2024
This preference list is to allow ECDSA sigalgs to be prioritized for policies that need legacy sigalg(SHA1) support. This change is needed because TLS1.3 is reliant on the sigalg preferences to drive server certificate preference selection.
|
I think this is ready, unless someone sees a blocker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This preference list is to allow ECDSA sigalgs to be prioritized for policies that need legacy sigalg(SHA1) support.
This change is needed because TLS1.3 is reliant on the sigalg preferences to drive server certificate preference selection.
Call-outs:
The list used in this change will be added to security_policy later.