Additional test cases for s2n_constant_time_equals() #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s NULL and the other is an array of N 0x00 bytes
jmayclin
reviewed
May 16, 2024
…declaration of new all_zero variable.
jmayclin
approved these changes
May 16, 2024
camshaft
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional test cases for s2n_constant_time_equals() where one parameter is NULL and the other is an array of N 0x00 bytes.
These cases are important owing to the implementation, where an 0x00 byte is substituted to avoid dereferencing NULL. In that case, we have to be careful to make sure this function returns FALSE, not TRUE.
Description of changes:
See above.
Call-outs:
There is potential to improve this code via more explicint pre-conditions that exclude the offending special cases.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.