chore: update s2n_stuffer_printf CBMC harness #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer CBMC versions ship a model of vsnprintf. We don't want to use this model for it contains loops, but still this highlighted a number of missing constraints in our existing harness.
lrstewart
reviewed
Apr 30, 2024
tests/cbmc/proofs/s2n_stuffer_printf/s2n_stuffer_printf_harness.c
Outdated
Show resolved
Hide resolved
tests/cbmc/proofs/s2n_stuffer_printf/s2n_stuffer_printf_harness.c
Outdated
Show resolved
Hide resolved
tests/cbmc/proofs/s2n_stuffer_printf/s2n_stuffer_printf_harness.c
Outdated
Show resolved
Hide resolved
lrstewart
reviewed
Jun 3, 2024
tests/cbmc/proofs/s2n_stuffer_printf/s2n_stuffer_printf_harness.c
Outdated
Show resolved
Hide resolved
lrstewart
approved these changes
Jun 12, 2024
WesleyRosenblum
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Newer CBMC versions ship a model of vsnprintf. We don't want to use this model for it contains loops, but still this highlighted a number of missing constraints in our existing harness.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.