fix: Fix redundant code #4504
Merged
fix: Fix redundant code #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Looks like we're doing this setup in the extended master secret test as well.
jmayclin
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves issue #4500 described here.
Description of changes:
Reducing redundant code by calling s2n_resumption_test_ticket_key_setup for test cases that manually sets the same ticket key.
Call-outs:
Testing:
Confirmed all unit tests passes by running
CTEST_PARALLEL_LEVEL=$(nproc) ctest --test-dir buildBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.