feat: add s2n_peek_buffered #4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
force-pushed
the
recv_buffering_2
branch
from
7b5b595 to
ea2f061
Compare
camshaft
reviewed
Apr 5, 2024
goatgoose
reviewed
Apr 5, 2024
camshaft
approved these changes
Apr 5, 2024
goatgoose
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Follow up to b169d76.
Add a method to check for buffered data.
Call-outs:
This returns a uint32_t to match s2n_peek, but should it? I'm not sure how useful knowing how much encrypted data exists is, since the caller can't map that to actual application data available. On the other hand, without recv_buffering the application could use recv + MSG_PEEK to get the same behavior, so maybe there's a use case we need to preserve.
Testing:
New unit test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.