feat: connection serialization #4468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
reviewed
Mar 25, 2024
lrstewart
reviewed
Mar 25, 2024
There was a problem hiding this comment.
Do "weirder tests" include tests like post-handshake messages? (key update, session ticket, renegotiation)
There was a problem hiding this comment.
Yep, do you think that they should be included in this PR? I didn't want to make this PR too large.
maddeleine
force-pushed
the
traffic_context
branch
2 times, most recently
from
238fce7 to
7fbd369
Compare
goatgoose
reviewed
Mar 28, 2024
lrstewart
reviewed
Mar 29, 2024
goatgoose
reviewed
Apr 1, 2024
maddeleine
commented
Apr 2, 2024
lrstewart
reviewed
Apr 2, 2024
goatgoose
approved these changes
Apr 2, 2024
goatgoose
reviewed
Apr 2, 2024
lrstewart
approved these changes
Apr 4, 2024
maddeleine
force-pushed
the
traffic_context
branch
from
cec3006 to
2a52356
Compare
lrstewart
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Description of changes:
Serializes the TLS connection and enables it to be sent off-box.
Call-outs:
Testing:
Includes basic self-talk tests. I will include the weirder tests in the next PR, as I think this PR will go through some iterations before we're satisfied with it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.