Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TLS 1.2 servers to report client versions from the supported versions extension #4249

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Allow TLS 1.2 servers to report client versions from the supported versions extension #4249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
78bd1a7
Allow TLS 1.2 servers to report client versions from the supported ve…
goatgoose Oct 17, 2023
02e65f8
pr feedback
goatgoose Oct 18, 2023
4fa3cb1
simplify tests
goatgoose Oct 19, 2023
949cd55
pr feedback
goatgoose Oct 20, 2023
3172e6d
simplify setting s2n_unknown_protocol_version
goatgoose Oct 24, 2023
8c86f7c
Merge branch 'main' into supported-versions-fix-3
goatgoose Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/integrationv2/test_version_negotiation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,12 @@ def test_s2nc_tls13_negotiates_tls12(managed_process, cipher, curve, certificate

for results in server.get_results():
results.assert_success()
# This check only cares about S2N. Trying to maintain expected output of other providers doesn't add benefit to
# whether the S2N client was able to negotiate a lower TLS version.
if provider is S2N:
# The server is only TLS12, so it reads the version from the CLIENT_HELLO, which is never above TLS12
# This check only cares about S2N. Trying to maintain expected output of other providers doesn't
# add benefit to whether the S2N client was able to negotiate a lower TLS version.
# The client sends a TLS 1.3 client hello so a client protocol version of TLS 1.3 should always be expected.
assert to_bytes("Client protocol version: {}".format(
actual_version)) in results.stdout
Protocols.TLS13.value)) in results.stdout
assert to_bytes("Actual protocol version: {}".format(
actual_version)) in results.stdout

Expand Down
Loading
Loading