Disable RC4 when built with Openssl-3.0 #3982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
reviewed
May 5, 2023
Comment on lines
26
to
+27
| #ifdef S2N_LIBCRYPTO_SUPPORTS_EVP_RC4 | ||
| return EVP_rc4(); |
There was a problem hiding this comment.
should this also check for Openssl-3?
There was a problem hiding this comment.
Nope. It's not testing for support, just limiting the blast radius of the #if we need to check for the existence of the EVP_rc4() symbol.
toidiu
approved these changes
May 5, 2023
jmayclin
approved these changes
May 5, 2023
camshaft
approved these changes
May 5, 2023
| @@ -21,20 +21,30 @@ | |||
| #include "utils/s2n_blob.h" | |||
| #include "utils/s2n_safety.h" | |||
|
|
|||
| static uint8_t s2n_stream_cipher_rc4_available() | |||
| static const EVP_CIPHER *s2n_evp_rc4() | |||
There was a problem hiding this comment.
It's hard to tell from the docs but does this EVP_CIPHER need to be free'd with EVP_CIPHER_free? Or is it a global?
|
Guess we will continue to support RC4 with Openssl3, since the other PR was merged :) |
auto-merge was automatically disabled
May 15, 2023 19:39
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
A possible alternative to #3980
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.