Removed codecov github status badge. #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Feb 28, 2023
README.md
Outdated
| [](https://codecov.io/gh/aws/s2n-tls) | ||
| [](https://codecov.io/gh/aws/s2n-tls?branch=main) |
There was a problem hiding this comment.
codecov.io doesn't play well with our safety macros: #3781. We should probably just remove it for now.
There was a problem hiding this comment.
Thanks, @lrstewart. What do you recommend, to close this PR or I can modify this to remove the codecov?
There was a problem hiding this comment.
I'd suggest modifying it to remove the codecov badge, if you're still interested in fixing the problem.
There was a problem hiding this comment.
I modified the PR. Thank you.
amazonKamath
changed the title
camshaft
approved these changes
Mar 1, 2023
lrstewart
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
None
Description of changes:
Codecov is not seen as best fit as per discussions - #3759 (comment) and #3781.
Call-outs:
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
Tested through visual inspection
Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.