Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org change to aws #2596

Merged
merged 24 commits into from
Mar 3, 2021
Merged

Org change to aws #2596

merged 24 commits into from
Mar 3, 2021

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Feb 18, 2021

Resolved issues:

Moving to AWS from AWSLabs

Description of changes:

Documentation update (and initial CI verification)

Call-outs:

Redirects are in place to mostly mask the move.

  • awslabs/s2n redirects to aws/s2n-tls
  • aws/s2n redirects to aws/s2n-tls

Testing:

This PR is the testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dougch dougch requested a review from ttjsu-aws February 18, 2021 20:28
Copy link
Contributor

@camshaft camshaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a bunch of references to s2n, not s2n-tls. But GitHub review won't let me comment on all of those.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
@dougch
Copy link
Contributor Author

dougch commented Feb 18, 2021

There's still a bunch of references to s2n, not s2n-tls. But GitHub review won't let me comment on all of those.

Was mostly focused on URLs, let me do another revision with a complete g/s//

@dougch dougch force-pushed the org_move branch 3 times, most recently from b4ea3d3 to ff59b5d Compare February 18, 2021 21:12
README.md Outdated Show resolved Hide resolved
docs/USAGE-GUIDE.md Outdated Show resolved Hide resolved
@ttjsu-aws
Copy link
Contributor

Some of the links seem to be broken due to a space introduced after s2n-tls and needs to be removed.

Ex: https://github.com/aws/s2n-tls /blob/main/tests/unit/.

@dougch dougch force-pushed the org_move branch 4 times, most recently from c35e220 to b23b262 Compare February 18, 2021 21:25
@dougch
Copy link
Contributor Author

dougch commented Feb 18, 2021

Some of the links seem to be broken due to a space introduced after s2n-tls and needs to be removed.

Ex: https://github.com/aws/s2n-tls /blob/main/tests/unit/.

regex got away from me; updated in recent push

Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
@dougch dougch requested a review from ttjsu-aws February 18, 2021 22:44
Co-authored-by: Tejeswini Sundaram <40477596+ttjsu-aws@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
docs/USAGE-GUIDE.md Outdated Show resolved Hide resolved
dougch and others added 2 commits February 19, 2021 11:26
Co-authored-by: Tejeswini Sundaram <40477596+ttjsu-aws@users.noreply.github.com>
@dougch dougch requested a review from ttjsu-aws February 19, 2021 19:32
@karkhaz
Copy link
Contributor

karkhaz commented Feb 19, 2021

Looking into these proof failures. It could be due to a new version of CBMC that was recently released. I'm going to downgrade CBMC to 5.15 and see if that helps.

Copy link
Contributor

@camshaft camshaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's also references to S2N ☹️

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/USAGE-GUIDE.md Outdated Show resolved Hide resolved
docs/USAGE-GUIDE.md Outdated Show resolved Hide resolved
dougch and others added 17 commits February 24, 2021 12:22
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
Co-authored-by: Tejeswini Sundaram <40477596+ttjsu-aws@users.noreply.github.com>
Co-authored-by: Tejeswini Sundaram <40477596+ttjsu-aws@users.noreply.github.com>
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
Co-authored-by: Cameron Bytheway <bytheway.cameron@gmail.com>
@dougch dougch merged commit b152cfb into aws:main Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants